feat!: no setters for enums in interfaces for java when allowInheritance is used #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for modelina canceled.
|
kennethaasan
changed the title
kennethaasan
changed the title
|
@jonaslagoni, please check. Can we instead check if the classes that implement interfaces have const set in them, or is this the only way? |
jonaslagoni
approved these changes
Jul 15, 2024
|
🎉 This PR is included in version 4.0.0-next.54 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jonaslagoni
reviewed
Jul 15, 2024
| @@ -10,6 +10,7 @@ import { FormatHelpers } from '../../../helpers'; | |||
| import { JavaOptions } from '../JavaGenerator'; | |||
| import { ClassPresetType } from '../JavaPreset'; | |||
| import { unionIncludesBuiltInTypes } from '../JavaConstrainer'; | |||
| import { isEnum } from '../../csharp/Constants'; | |||
There was a problem hiding this comment.
Think it's time to move this to general 😆
4 tasks
|
🎉 This issue has been resolved in version 4.0.0-next.60 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Java, when a class implements an interface, it must implement all the methods of that interface. Because of that, Modelina now doesn't render the setter for enums in interfaces when
allowInheritanceis true because the classes that implement the interface might use a constant value.Related Issue
Checklist
npm run lint).npm run test).Additional Notes